rsx: Surface cache fixups (part 1) #6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Carve out inherited region if any - Perform pitch compatibility test before assigning old_surface
|
|
|
Here's the difference |
|
Some more investigation revealed the probable cause of the excessive lightshafts to be a bit more complicated (they were missing before which is worse). If I confirm my findings then we can move forward and merge this first before the rest of the patches can be submitted. |
|
Confirmed race conditions between Cell rendering and RSX rendering; will submit followup synchronization patches later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to be part of a larger changeset but some other investigations are holding things back a bit so I decided to go ahead and submit this as a astandalone. Continuation of work on #5983